Skip to content

Update CI to support +ipopt (^ipopt~coinhsl+mumps), +asan and +ubsan.#139

Merged
pelesh merged 1 commit into
developfrom
nicholson/CI-upgrades
Jun 25, 2025
Merged

Update CI to support +ipopt (^ipopt~coinhsl+mumps), +asan and +ubsan.#139
pelesh merged 1 commit into
developfrom
nicholson/CI-upgrades

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Jun 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

CI support for sanitizers and Ipopt
Closes #136

Proposed changes

  • Added asan and ubsan variants to the GridKit Spack package
  • Loosened the Ipopt dependency requirement for GridKit, such that we can build with mumps (without MPI) instead of coinhsl. A minor bug in the mumps Spack package previously prevented this from working.
  • Activated those options in GridKit CI.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@nkoukpaizan nkoukpaizan self-assigned this Jun 13, 2025
@nkoukpaizan nkoukpaizan force-pushed the nicholson/CI-upgrades branch from ba317c3 to dbca824 Compare June 18, 2025 18:46
@nkoukpaizan nkoukpaizan marked this pull request as ready for review June 18, 2025 19:11
@nkoukpaizan nkoukpaizan added enhancement New feature or request development Features/Tools related to development of GridKit, rather than use as a library. labels Jun 18, 2025
@superwhiskers

superwhiskers commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

if this works i don't see anything wrong with it

@pelesh pelesh merged commit 16d09e8 into develop Jun 25, 2025
4 checks passed
@nkoukpaizan nkoukpaizan deleted the nicholson/CI-upgrades branch June 30, 2025 15:08
WiktoriaZielinskaORNL pushed a commit that referenced this pull request Jul 23, 2025
@nkoukpaizan
Update CI to support +ipopt (^ipopt~coinhsl+mumps), +asan and +ubsan. (…
dd22690 
…#139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superwhiskers superwhiskers superwhiskers approved these changes
@pelesh pelesh pelesh approved these changes

Assignees

@nkoukpaizan nkoukpaizan

Labels

development Features/Tools related to development of GridKit, rather than use as a library. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enable address sanitizer in ci

3 participants

@nkoukpaizan @superwhiskers @pelesh